fix(style-guides): simplify dual-platform models with optional groupId#639
Merged
andrii-bodnar merged 1 commit intomasterfrom Mar 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 41 41
Lines 2126 2126
Branches 254 254
=======================================
Hits 1910 1910
Misses 82 82
Partials 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(style-guides): simplify dual-platform models with optional groupId
Summary
Simplifies Style Guides API models to use a single interface with optional
groupIdinstead of separate Crowdin/Enterprise interfaces. Aligns with the pattern used inmachineTranslationand other dual-platform modules.Changes
StyleGuide: Added optionalgroupId?: number(Enterprise only) instead ofStyleGuideEnterpriseinterfaceCreateStyleGuideRequest: Added optionalgroupId?: number | null(Enterprise only) instead ofCreateStyleGuideEnterpriseRequestStyleGuide | StyleGuideEnterprise), now returnStyleGuidedirectlygroupIdaccessRationale
Style Guides API serves both Crowdin and Crowdin Enterprise. The only platform-specific difference is
groupId(Enterprise). Using optionalgroupIdkeeps the API surface simpler and consistent.